Bug 261471
| Summary: | REGRESSION(267765@main) builtins-generator suite is failing with wrong copyright and outdated baseline | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | JavaScriptCore | Assignee: | Lauro Moura <lmoura> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | keith_miller, webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=242537 | ||
Lauro Moura
Example of failed run from wpe builder: https://build.webkit.org/#/builders/40/builds/11923/steps/21/logs/stdio
Two issues:
- The copyright template in `builtins_templates.py` doesn't need the end year, which is added by `BuiltinsCollection.copyrights()` from `builtins_model.py`.
- The results needed to be updated with `--reset-results` to account for the new `JSC::SourceTaintedOrigin::Untainted` parameter.
Patch incoming
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/17698
Radar WebKit Bug Importer
<rdar://problem/115736986>
EWS
Committed 268401@main (e911779c50f0): <https://commits.webkit.org/268401@main>
Reviewed commits have been landed. Closing PR #17698 and removing active labels.