Bug 26136

Summary:

Update WinLauncher for WebKitCreateInstance

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Update Windows example for current WebKit techniques.	none
Remove use of CoCreateInstance	none
Switch from CoCreateInstance to WebKitCreateInstance	none
Complete patch this time.	aroben: review+

Brent Fulgham

Reported 2009-06-02 10:01:34 PDT

A very common problem when attempting to use WebKit is setting up proper link parameters (and manifest flags) so that the various WebKit objects are accessible via the CoCreateInstance infrastructure. This was remedied by the creation of the WebKitCreateInstance method, which removes a lot of the guesswork in setting up and using WebKit. This patch modifies the WinLauncher example program to use WebKitCreateInstance so that a good example of WebKit use is available for prospective users.

Attachments
Update Windows example for current WebKit techniques. (7.80 KB, patch) 2009-06-02 10:40 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Remove use of CoCreateInstance (2.38 KB, patch) 2009-06-02 11:05 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Switch from CoCreateInstance to WebKitCreateInstance (2.29 KB, patch) 2009-06-02 11:06 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Complete patch this time. (5.52 KB, patch) 2009-06-02 11:09 PDT, Brent Fulgham	aroben: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2009-06-02 10:40:23 PDT

Created attachment 30873 [details] Update Windows example for current WebKit techniques. A patch to make the WinLauncher program a better example for prospective Windows WebKit users.

Brent Fulgham

Comment 2 2009-06-02 11:05:05 PDT

Created attachment 30874 [details] Remove use of CoCreateInstance Remove use of ATL CComPTR smart pointers, as they are not available in VS C++ Express.

Brent Fulgham

Comment 3 2009-06-02 11:06:43 PDT

Created attachment 30875 [details] Switch from CoCreateInstance to WebKitCreateInstance Remove use of ATL-specific CComPTR smart pointer, since it is not available in VC++ Express.

Brent Fulgham

Comment 4 2009-06-02 11:09:42 PDT

Created attachment 30876 [details] Complete patch this time. Remove use of ATL-only CComPTR, as it is not present in VC++ Express libraries.

Adam Roben (:aroben)

Comment 5 2009-06-02 11:12:20 PDT

Comment on attachment 30876 [details] Complete patch this time. r=me

Brent Fulgham

Comment 6 2009-06-02 12:03:19 PDT

Landed in @r44363.

Note You need to log in before you can comment on or make changes to this bug.