Bug 26124

Summary: resolve-ChangeLogs --continue hangs if git rebase --continue needs to launch $EDITOR
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: aroben, ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on: 21418    
Bug Blocks:    

Description Eric Seidel (no email) 2009-06-01 16:30:37 PDT
resolve-ChangeLogs --continue hangs if git rebase --continue needs to launch $EDITOR

eseidel-mac [6520:WebKit]% resolve-ChangeLogs -c                               
                                        [~/Projects/WebKit]

M       WebCore/ChangeLog
Running 'git rebase --continue'...
Vim: Warning: Output is not to a terminal

And the terminal is hung. ;)

I'm not sure what the conditions under which it decides it needs to launch an editor are...
Comment 1 David Kilzer (:ddkilzer) 2009-06-01 20:34:54 PDT
I suppose we should just "exec" git-rebase since it's essentially the last thing that's ever done if you enable that command-line switch.