Bug 26123

Summary: KURL::KURL() seems to have a redundant checkEncodedString call
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
A patch that removes the redundant call. darin: review+

Jeremy Orlow
Reported 2009-06-01 16:12:15 PDT
KURL::KURL() seems to have a redundant checkEncodedString() call since the first thing KURL::parse() does is run checkEncodedString(). Changing something like this seems scary, but it seemed worth submitting in case this really is an oversight.
Attachments
A patch that removes the redundant call. (899 bytes, patch)
2009-06-01 16:13 PDT, Jeremy Orlow 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2009-06-01 16:13:32 PDT
Created attachment 30843 [details] A patch that removes the redundant call.
Jeremy Orlow
Comment 2 2009-06-01 18:43:14 PDT
I'm not a committer, so please land the patch for me? Thanks! P.S. I just noticed that checkEncodedString is only run in debug mode, so this patch probably isn't super critical. If you want to mark this WONTFIX, I won't be offended. :-)
Adam Barth
Comment 3 2009-06-01 23:35:33 PDT
Will land.
Adam Barth
Comment 4 2009-06-01 23:42:17 PDT
Sending WebCore/ChangeLog Sending WebCore/platform/KURL.cpp Transmitting file data .. Committed revision 44348.
Note You need to log in before you can comment on or make changes to this bug.