Bug 261127
| Summary: | Let the compiler generate more comparison operators in JSC | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | JavaScriptCore | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, darin, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=264896 | ||
Chris Dumez
Let the compiler generate more comparison operators in JSC now that we support C++20.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/17417
EWS
Committed 267645@main (e9e93692891c): <https://commits.webkit.org/267645@main>
Reviewed commits have been landed. Closing PR #17417 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/115001681>
Chris Dumez
This caused a 3MB binary size increase and I am unclear why. The compiler should in theory generate identical code to the one we had..
At first I thought it was because I newly inlined 2 of the comparison operators. However, moving them back out of line didn't reduce binary size significantly.
Darin Adler
Maybe the generated ones are always implicitly generated inline?