Bug 261096

Summary: Change --logJIT to dump its header line on a single line.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Mark Lam 2023-09-03 21:20:26 PDT
It currently dumps one "Generated JIT code for ..." line and a second line indicating the bounds of the JIT code.  This patch makes the 2 into 1 line, and adds JITCode size in bytes to the dump.  This makes the dump easier to filter out / grep for info about certain JIT code generation.

Other miscellaneous changes:
1. Removed unused --dumpCompilerConstructionSite option.
2. Changed JITPlan::compileInThread to cache the result of computeCompileTimes(), and to return early if it is false.  The rest of the function after the call to compileInThreadImpl() are all to do dumps.  Those dumps are gated on conditions which will cause computeCompileTimes() to return true if the dump is needed.  Hence, there's no need to do extra work if computeCompileTimes() is false.
Comment 1 Radar WebKit Bug Importer 2023-09-03 21:20:43 PDT
<rdar://problem/114916585>
Comment 2 Mark Lam 2023-09-03 21:24:10 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17397
Comment 3 EWS 2023-09-05 11:15:43 PDT
Committed 267639@main (aaec31beee6c): <https://commits.webkit.org/267639@main>

Reviewed commits have been landed. Closing PR #17397 and removing active labels.