Bug 261066
| Summary: | Handle NaN in the Audio delay curves | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Web Audio | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 16 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
Based on Slack's discussion with Chris 1:1, it is potential merge from Blink:
Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/f6e3d4665d9261e4fef2b5931e4c75ecb5e032bf
WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp#124
______
It is fixed by following:
double delayTime = m_delayTimes[i];
if (std::isnan(delayTime))
delayTime = maxDelayTime();
else
delayTime = std::clamp<double>(m_delayTimes[i], 0.0, maxDelayTime());
____
Raising this bug so we can fix it in WebKit as well.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 267589@main (138a64742ac6): <https://commits.webkit.org/267589@main>
Reviewed commits have been landed. Closing PR #17377 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/114881060>