Bug 260867

Summary: REGRESSION(267279@main): [ macOS wk2 ] fast/canvas/webgl/texImage2D-mse-flipY-false.html is a consistent text failure.
Product: WebKit Reporter: Ben Schwartz <ben_schwartz>
Component: WebGLAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jean-yves.avenard, kbr, kkinnunen, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=260185
https://bugs.webkit.org/show_bug.cgi?id=260742
https://bugs.webkit.org/show_bug.cgi?id=260833
https://bugs.webkit.org/show_bug.cgi?id=261335
https://bugs.webkit.org/show_bug.cgi?id=261911

Description Ben Schwartz 2023-08-29 11:11:41 PDT
fast/canvas/webgl/texImage2D-mse-flipY-false.html

This test is a consistent text failure on macOS wk2 (including gpuprocess).

HISTORY:

https://results.webkit.org/?suite=layout-tests&test=fast%2Fcanvas%2Fwebgl%2FtexImage2D-mse-flipY-false.html&platform=mac&flavor=wk2&flavor=gpuprocess

TEXT DIFF:

 Setting video src.
 Video can play.
 Checking the canvas pixels.
-PASS: Bottom edge is red.
-PASS: Top edge is blue.
+FAIL: Bottom edge is not red.
+FAIL: Top edge is not blue.

DIFF URL:

https://build.webkit.org/results/Apple-Ventura-Release-AppleSilicon-WK2-Tests/267407%40main%20(4683)/fast/canvas/webgl/texImage2D-mse-flipY-false-pretty-diff.html

REPRODUCTION:

I was able to reproduce this bug on macOS Ventura (13.5, 22G74/arm64) using the following command:

run-webkit-tests --verbose --iterations 50 --clobber-old-results --exit-after-n-failures 1 fast/canvas/webgl/texImage2D-mse-flipY-false.html

REGRESSION:

I was able to bisect a regression point. This bug reproduced at 267279@main, but it did not reproduce at 267278@main. Changes at 267279@main appear to be directly related to this error, and is likely what caused the failure.
Comment 1 Radar WebKit Bug Importer 2023-08-29 11:11:54 PDT
<rdar://problem/114642707>
Comment 2 EWS 2023-08-29 11:24:54 PDT
Test gardening commit 267412@main (281b7e80b1ea): <https://commits.webkit.org/267412@main>

Reviewed commits have been landed. Closing PR #17191 and removing active labels.
Comment 3 Ben Schwartz 2023-09-07 23:13:22 PDT
This text expectation was removed by mistake in 267723@main (the issue has not yet been resolved -- see rdar://problem/114642707). Re-setting test expectation.
Comment 4 EWS 2023-09-07 23:22:25 PDT
Test gardening commit 267770@main (b96a43544d41): <https://commits.webkit.org/267770@main>

Reviewed commits have been landed. Closing PR #17578 and removing active labels.
Comment 5 Jean-Yves Avenard [:jya] 2023-09-08 07:48:15 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17591
Comment 6 EWS 2023-09-08 16:30:01 PDT
Committed 267814@main (324ba3da764b): <https://commits.webkit.org/267814@main>

Reviewed commits have been landed. Closing PR #17591 and removing active labels.
Comment 7 Ben Schwartz 2024-05-31 20:09:59 PDT
This no longer appears to be occurring. Removing test expectations.

Tracking test expectations removal in bug #274990 (rdar://129080660).