Bug 260750
| Summary: | Placate exception check validation in sanitizeRemoteFunctionException. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
sanitizeRemoteFunctionException() can call JSValue::toWTFString() which may throw under certain circumstances. However, it is only called here if exceptionValue.isPrimitive() i.e. it will never throw. However, the exception check validator does not know this. So, we added a `ASSERT(!scope.exception())` to placate it.
However, if we're forcing exception check validation on a Release build, the ASSERT turns into a no-op. The fix is to use EXCEPTION_ASSERT here instead.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/114477714>
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/17093
EWS
Committed 267311@main (9b124cc4e156): <https://commits.webkit.org/267311@main>
Reviewed commits have been landed. Closing PR #17093 and removing active labels.