| Summary: | [GTK] Refactor key scrolling code | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Xan Lopez <xan.lopez> | ||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
|
Description
Xan Lopez
2009-05-29 02:36:46 PDT
Created attachment 30770 [details]
scroll.patch
This seems to break scrolling in the Acid2 test :/ I thought we were always guaranteed to have a scrollbar, even if it would be a dummy one, but apparently in that case WebCore thinks we don't have one and scrolling fails when using ScrollView::scroll. Guess I'm missing something here? Created attachment 30774 [details]
scrollv2.patch
Be more consistent with our previous implementation, always return true and do not scroll parent views (not sure if that's correct or not). My previous comment still applies though.
Comment on attachment 30774 [details]
scrollv2.patch
Looks good to me. Testing in Chromium/Linux and asking people to test on Safari indicates that not scrolling in acid2 is actually the right thing, so this fixes a bug =).
|