Bug 260745
| Summary: | RETURN_IF_EXCEPTION should work for Release builds too. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
In PlatformEnable.h, we can force ENABLE_EXCEPTION_SCOPE_VERIFICATION to be on so that we can get validate exception checks with a Release build. However, RETURN_IF_EXCEPTION is relying on an ASSERT to tickle the exception check validator. The right thing to do is to use EXCEPTION_ASSERT instead.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/114475322>
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/17090
EWS
Committed 267303@main (c0b02e6b685b): <https://commits.webkit.org/267303@main>
Reviewed commits have been landed. Closing PR #17090 and removing active labels.