Bug 26074

Summary: SQLTransaction::executeSQL does an unnecessary call to String::copy.
Product: WebKit Reporter: David Levin <levin>
Component: WebCore Misc.Assignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed fix. darin: review+

David Levin
Reported 2009-05-29 01:09:27 PDT
The 1st argument is a string that is copied in this call: ... SQLStatement::create(sqlStatement.copy(), ...); SQLStatement also copies this string (see WebCore/storage/SQLStatement.cpp): SQLStatement::SQLStatement(const String& statement, ...) : m_statement(statement.copy())
Attachments
Proposed fix. (1.34 KB, patch)
2009-05-29 01:13 PDT, David Levin 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-05-29 01:13:11 PDT
Created attachment 30767 [details] Proposed fix.
Brent Fulgham
Comment 2 2009-05-29 14:38:39 PDT
Landed in @r44274.
Note You need to log in before you can comment on or make changes to this bug.