Bug 26072

Summary: Add WML <select> element support
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: WebCore Misc.Assignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: staikos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 20393    
Attachments:
Description Flags
Initial patch staikos: review+

Nikolas Zimmermann
Reported 2009-05-28 16:59:25 PDT
Add support for the last missing WML element: <select>. A first version of this patch will only add the WMLSelectElement skeleton and integrate it. WML specific features (variable substitution etc.) will follow afterwards.
Attachments
Initial patch (71.52 KB, patch)
2009-05-28 17:10 PDT, Nikolas Zimmermann 		staikos: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2009-05-28 17:10:03 PDT
Created attachment 30759 [details] Initial patch Adding initial version of the patch.
Nikolas Zimmermann
Comment 2 2009-05-29 18:40:56 PDT
Landed in r44283.
Darin Adler
Comment 3 2009-05-30 13:44:53 PDT
Comment on attachment 30759 [details] Initial patch This patch broke tab key handling when the focus is on a <select> element.
George Staikos
Comment 4 2009-05-30 18:24:41 PDT
Appears to have been fixed now, correct?
Nikolas Zimmermann
Comment 5 2009-05-30 19:47:25 PDT
(In reply to comment #4) > Appears to have been fixed now, correct? Yes Darin already took care of fixing the regression. Thanks for that!
Note You need to log in before you can comment on or make changes to this bug.