Bug 26069

Summary:

Fix a crash in custom V8 bindings code for XMLHttpRequest.

Product:

WebKit

Reporter:

Jian Li <jianli>

Component:

WebCore Misc.

Assignee:

Jian Li <jianli>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Patch	none
Proposed Patch	dglazkov: review+

Jian Li

Reported 2009-05-28 14:47:25 PDT

Fix a crash in custom V8 bindings code for XMLHttpRequest. Please see http://code.google.com/p/chromium/issues/detail?id=12792 for more details.

Attachments
Proposed Patch (1.71 KB, patch) 2009-05-28 14:54 PDT, Jian Li	no flags	Details Formatted Diff Diff
Proposed Patch (4.46 KB, patch) 2009-05-29 14:12 PDT, Jian Li	dglazkov: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jian Li

Comment 1 2009-05-28 14:54:40 PDT

Created attachment 30753 [details] Proposed Patch

Dimitri Glazkov (Google)

Comment 2 2009-05-28 16:36:08 PDT

Is there a layout test that we could be used to exercise this fix?

Jian Li

Comment 3 2009-05-28 17:07:02 PDT

(In reply to comment #2) > Is there a layout test that we could be used to exercise this fix? > I am afraid no. I could add one in WebKit. How do you think?

Jian Li

Comment 4 2009-05-29 14:12:05 PDT

Created attachment 30788 [details] Proposed Patch

Dimitri Glazkov (Google)

Comment 5 2009-05-29 14:33:54 PDT

Comment on attachment 30788 [details] Proposed Patch Excellent.

Jian Li

Comment 6 2009-05-29 16:18:13 PDT

Committed as http://trac.webkit.org/changeset/44275.

Note You need to log in before you can comment on or make changes to this bug.