Bug 26069

Summary:

Fix a crash in custom V8 bindings code for XMLHttpRequest.

Product:

WebKit

Reporter:

Jian Li <jianli>

Component:

WebCore Misc.

Assignee:

Jian Li <jianli>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Patch	none
Proposed Patch	dglazkov: review+

Description Jian Li 2009-05-28 14:47:25 PDT

Fix a crash in custom V8 bindings code for XMLHttpRequest. Please see
http://code.google.com/p/chromium/issues/detail?id=12792 for more details.

Comment 1 Jian Li 2009-05-28 14:54:40 PDT

Created attachment 30753 [details]
Proposed Patch

Comment 2 Dimitri Glazkov (Google) 2009-05-28 16:36:08 PDT

Is there a layout test that we could be used to exercise this fix?

Comment 3 Jian Li 2009-05-28 17:07:02 PDT

(In reply to comment #2)
> Is there a layout test that we could be used to exercise this fix?
> 

I am afraid no. I could add one in WebKit. How do you think?

Comment 4 Jian Li 2009-05-29 14:12:05 PDT

Created attachment 30788 [details]
Proposed Patch

Comment 5 Dimitri Glazkov (Google) 2009-05-29 14:33:54 PDT

Comment on attachment 30788 [details]
Proposed Patch

Excellent.

Comment 6 Jian Li 2009-05-29 16:18:13 PDT

Committed as http://trac.webkit.org/changeset/44275.