Bug 26048

Summary: navigation-policy-decision-requested documentation incomplete
Product: WebKit Reporter: Adrian Bunk <bunk>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Improve policy decision signals documentation xan.lopez: review+

Adrian Bunk
Reported 2009-05-27 14:38:11 PDT
I was quite surprised to hear that when returning TRUE from a navigation-policy-decision-requested handler, it is expected that webkit_policy_decision_* was called on policy_decision. Please add this information to http://webkitgtk.org/reference/webkitgtk-WebKitWebView.html#WebKitWebView-navigation-policy-decision-requested
Attachments
Improve policy decision signals documentation (2.95 KB, patch)
2009-05-28 11:17 PDT, Gustavo Noronha (kov) 		xan.lopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2009-05-28 11:17:50 PDT
Created attachment 30741 [details] Improve policy decision signals documentation WebKit/gtk/ChangeLog | 14 ++++++++++++++ WebKit/gtk/webkit/webkitwebview.cpp | 21 +++++++++++++++++++++ 2 files changed, 35 insertions(+), 0 deletions(-)
Gustavo Noronha (kov)
Comment 2 2009-05-28 11:39:59 PDT
Landed as r44248, with a small addition I talked to Xan about on IRC.
Note You need to log in before you can comment on or make changes to this bug.