Summary: | [IFC] Cache canUseSimplifiedTextMeasuring on RenderText | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
zalan
2023-08-19 05:29:47 PDT
Created attachment 467341 [details]
Patch
Created attachment 467342 [details]
[fast-cq]Patch
Comment on attachment 467342 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467342&action=review > Source/WebCore/rendering/RenderText.h:258 > std::optional<float> m_minWidth; > std::optional<float> m_maxWidth; > + std::optional<bool> m_canUseSimplifiedTextMeasuring { }; These waste some space. (In reply to Antti Koivisto from comment #4) > Comment on attachment 467342 [details] > [fast-cq]Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467342&action=review > > > Source/WebCore/rendering/RenderText.h:258 > > std::optional<float> m_minWidth; > > std::optional<float> m_maxWidth; > > + std::optional<bool> m_canUseSimplifiedTextMeasuring { }; > > These waste some space. Indeed. Will take care of that in a separate patch. Committed 267081@main (8f6d89b32a38): <https://commits.webkit.org/267081@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467342 [details]. |