Bug 26012

Summary: Chromium doesn't handle -webkit-border-image correctly.
Product: WebKit Reporter: Stephen White <senorblanco>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: senorblanco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Fix for Chromium Image::drawPattern() issue.
dglazkov: review+
Fix ChangeLog dglazkov: review+

Description Stephen White 2009-05-25 12:16:55 PDT
Chromium (skia) doesn't do -webkit-border-image correctly when the border image is 1 pixel wide or high, since it doesn't like negative width/height source rects in Image::drawPattern().  CoreGraphics will happily draw it in this case.  See bug http://crbug.com/6167.
Comment 1 Stephen White 2009-05-25 12:20:29 PDT
Created attachment 30658 [details]
Fix for Chromium Image::drawPattern() issue.
Comment 2 Mark Rowe (bdash) 2009-05-25 14:37:22 PDT
Putting Brett as the reviewer doesn't make much sense as Brett is not a WebKit reviewer.  We don't typically nominate a specific reviewer anyway.
Comment 3 Stephen White 2009-05-26 07:42:02 PDT
(In reply to comment #2)
> Putting Brett as the reviewer doesn't make much sense as Brett is not a WebKit
> reviewer.

Whoops, will fix.

> We don't typically nominate a specific reviewer anyway.

In my experience, patches tend to get ignored if you don't.
Comment 4 Dimitri Glazkov (Google) 2009-05-26 08:01:59 PDT
Comment on attachment 30658 [details]
Fix for Chromium Image::drawPattern() issue.

Thanks for fixing this!

Don't forget a bug URL in the ChangeLog.
Comment 5 Stephen White 2009-05-26 08:15:30 PDT
Created attachment 30669 [details]
Fix ChangeLog
Comment 6 Dimitri Glazkov (Google) 2009-05-26 09:00:56 PDT
Landed as http://trac.webkit.org/changeset/44150.