Bug 26004

Summary: postMessage origin should follow lexical scope
Product: WebKit Reporter: Adam Barth <abarth>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch mjs: review+

Adam Barth
Reported 2009-05-24 23:58:15 PDT
postMessage origin should follow lexical scope, but it's currently using the dynamic scope. Patch forthcoming.
Attachments
patch (8.15 KB, patch)
2009-05-25 00:04 PDT, Adam Barth 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-05-25 00:04:34 PDT
Created attachment 30643 [details] patch I even remembered to link to the bug.
Maciej Stachowiak
Comment 2 2009-05-25 00:48:14 PDT
Comment on attachment 30643 [details] patch r=me I'm not 100% sure of the v8 part but it looks close enough to me. Also I am surprised that setting document.domain to "0.0.1" works - that's probably a bug.
Adam Barth
Comment 3 2009-05-25 01:59:58 PDT
Fixed in r44124.
David Kilzer (:ddkilzer)
Comment 4 2009-05-26 06:20:40 PDT
<rdar://problem/6921231>
David Kilzer (:ddkilzer)
Comment 5 2009-06-03 16:48:27 PDT
(In reply to comment #3) > Fixed in r44124. <http://trac.webkit.org/changeset/44124> ChangeLog typo fixed: <http://trac.webkit.org/changeset/44125> Follow-up layout test fix: <http://trac.webkit.org/changeset/44133> Follow-up layout test fix #2: <http://trac.webkit.org/changeset/44134>
Note You need to log in before you can comment on or make changes to this bug.