Bug 26000

Summary:

prepare-ChangeLog should convert windows style backslashes in file paths

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

Tools / Tests

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
patch	darin: review+

Darin Fisher (:fishd, Google)

Reported 2009-05-24 23:31:12 PDT

prepare-ChangeLog should convert windows style backslashes in file paths if you use a windows build of subversion, then you will end up with backslashes in the file paths of the ChangeLog. for readability and perhaps to help with scripts that may operate on ChangeLog, we should try to make prepare-ChangeLog smarter.

Attachments
patch (3.75 KB, patch) 2009-06-16 00:35 PDT, Adam Barth	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2009-06-16 00:35:54 PDT

Created attachment 31338 [details] patch This patch also normalizes line ends as well as backslashes. Yay for platform uniformity!

Adam Barth

Comment 2 2009-06-16 00:37:27 PDT

It's a race to see which Darin reviews this patch first!

Darin Fisher (:fishd, Google)

Comment 3 2009-06-16 07:10:55 PDT

Thanks for patching this, Adam!

Adam Barth

Comment 4 2009-06-16 11:09:31 PDT

http://trac.webkit.org/changeset/44716

Note You need to log in before you can comment on or make changes to this bug.