Bug 25999

Summary:

Chromium build bustage related to PassOwnPtr

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

Platform

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
v1 patch	mrowe: review+

Description Darin Fisher (:fishd, Google) 2009-05-24 23:16:09 PDT

Chromium build bustage related to PassOwnPtr

Changes:
http://trac.webkit.org/changeset/44098
http://trac.webkit.org/changeset/44099

Build bustage observed here:
http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20(webkit.org)/builds/4277/steps/compile/logs/stdio

Comment 1 Darin Fisher (:fishd, Google) 2009-05-24 23:22:00 PDT

Created attachment 30641 [details]
v1 patch

Comment 2 Mark Rowe (bdash) 2009-05-24 23:25:53 PDT

Comment on attachment 30641 [details]
v1 patch

Build fixes typically don't need review.

Comment 3 Darin Fisher (:fishd, Google) 2009-05-24 23:29:15 PDT

Landed as:  http://trac.webkit.org/changeset/44123

Comment 4 Maciej Stachowiak 2009-05-25 02:21:29 PDT

Although review is not mandatory for build fixes, there's nothing wrong with getting review, especially if there are people around to look at the fix.