| Summary: | Detect UA transitions on same-document navigations | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | khush <khushalsagar> |
| Component: | History | Assignee: | Rob Buis <rbuis> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | annevk, beidson, simon.fraser, thorton, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=271886 | ||
| Bug Depends on: | 264730 | ||
| Bug Blocks: | 264748 | ||
|
Description
khush
2023-08-03 12:59:29 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18756 Committed 270589@main (f034bb9b9246): <https://commits.webkit.org/270589@main> Reviewed commits have been landed. Closing PR #18756 and removing active labels. The value for hasUAVisualTransition should be true if the browser does an animation from a user swipe when navigating. I don't think that was done in the PR linked below. (In reply to khush from comment #4) > The value for hasUAVisualTransition should be true if the browser does an > animation from a user swipe when navigating. I don't think that was done in > the PR linked below. You are right, more work is needed. Note though that the default behaviour of github merge-queue logic lands the PR and closes the associated bug, which is what happened here. Let's leave this as fixed to keep Bugzilla/Radar/GitHub in sync. Bug 264730 will put this behind a flag so it's not shipped in this state. Bug 264748 tracks macOS/iOS implementation. Once those are in place this can be reconsidered for enablement. I've put up bug 271886 for enabling this by default. |