| Summary: | build-launcher-dmg depends on drosera | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | mrowe | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
Created attachment 30613 [details]
fix build-launcher to run w/o drosera
2 files changed, 14 insertions(+), 5 deletions(-)
Comment on attachment 30613 [details]
fix build-launcher to run w/o drosera
As I mentioned on IRC, I'd prefer that you not land this at the moment as I intend to replace this script, and others that are part of the nightly build process, with my current versions in the near future. Making changes to it in the mean time will just make my merging for nightly builds more painful. The script has been broken for over a year already, so I don't think a few more weeks will hurt.
Yup, no problem. |
build-launcher-dmg depends on drosera It shouldn't. Drosera is long dead. I use this script to build launchable dmgs which I can pass to other teams in Google to verify fixes before sending the fixes out for patch review. It broke a while back and I've been meaning to post a fix. Finally doing so. Mark didn't sound very keen on me fixing this script. But I'm posting this anyway so it's off my harddrive.