Bug 259750
| Summary: | [import-w3c-tests] invalid options/arguments don't cause an error | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=257198 https://bugs.webkit.org/show_bug.cgi?id=257674 |
||
Sam Sneddon [:gsnedders]
Running:
```
./Tools/Scripts/import-w3c-tests web-platform-tests/css/selectors --clear-dest-dir -a -t
```
Doesn't result in any error.
However, `--clear-dest-dir` isn't the name of an option—`--clean-dest-dir` is. I'd expect, in typical shell fashion, the unknown option to cause an error, not be treated as an argument.
We should probably also make:
```
./Tools/Scripts/import-w3c-tests nonsense/foo/bar
```
Fail, as we practically require the string to start with web-platform-tests.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/113293027>
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/16331
EWS
Committed 266587@main (b696c86a2c86): <https://commits.webkit.org/266587@main>
Reviewed commits have been landed. Closing PR #16331 and removing active labels.