Summary: | [V8] Enable timers in Chromium workers | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dmitry Titov <dimich> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, jianli | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Dmitry Titov
2009-05-22 18:26:06 PDT
Created attachment 30602 [details]
Proposed patch
Comment on attachment 30602 [details] Proposed patch Fine to land after addressing these style nits. > + } else { > + scriptController->evaluate(m_code); > + } No braces here? > + v8::Handle<v8::Value> function = args[0]; > + int32_t timeout = argumentCount >= 2 ? args[1]->Int32Value() : 0; Weird spacing thing? Fixed according to Dimitri's comments and landed: http://trac.webkit.org/changeset/44160 Chromium fix landed as http://trac.webkit.org/changeset/44202. I should've picked this up during review :-\. |