Bug 25974

Summary: [V8] Enable timers in Chromium workers
Product: WebKit Reporter: Dmitry Titov <dimich>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, jianli
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch dglazkov: review+

Dmitry Titov
Reported 2009-05-22 18:26:06 PDT
Updated V8 versions of ScheduledAction and WorkerContextCustom to actually invoke timers from workers in Chromium.
Attachments
Proposed patch (7.60 KB, patch)
2009-05-22 18:50 PDT, Dmitry Titov 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dmitry Titov
Comment 1 2009-05-22 18:50:42 PDT
Created attachment 30602 [details] Proposed patch
Dimitri Glazkov (Google)
Comment 2 2009-05-25 10:30:48 PDT
Comment on attachment 30602 [details] Proposed patch Fine to land after addressing these style nits. > + } else { > + scriptController->evaluate(m_code); > + } No braces here? > + v8::Handle<v8::Value> function = args[0]; > + int32_t timeout = argumentCount >= 2 ? args[1]->Int32Value() : 0; Weird spacing thing?
Dmitry Titov
Comment 3 2009-05-26 14:51:22 PDT
Fixed according to Dimitri's comments and landed: http://trac.webkit.org/changeset/44160
Dimitri Glazkov (Google)
Comment 4 2009-05-27 15:17:01 PDT
Chromium fix landed as http://trac.webkit.org/changeset/44202. I should've picked this up during review :-\.
Note You need to log in before you can comment on or make changes to this bug.