Bug 25971

Summary:

Some Video Elements Creeping Into Non-Video Builds

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Regression

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Correct a few build errors.	aroben: review+

Brent Fulgham

Reported 2009-05-22 16:27:01 PDT

The Windows Cairo variant fails to build at the moment because a few media controller files are getting included in the standard build. The attached patch corrects this problem for users who disabled the VIDEO build option.

Attachments
Correct a few build errors. (7.95 KB, patch) 2009-05-22 17:45 PDT, Brent Fulgham	aroben: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2009-05-22 17:45:47 PDT

Created attachment 30598 [details] Correct a few build errors.

Adam Roben (:aroben)

Comment 2 2009-05-22 17:47:20 PDT

Comment on attachment 30598 [details] Correct a few build errors. > +++ WebCore/rendering/RenderThemeWin.cpp (working copy) > @@ -28,7 +28,9 @@ > #include "HTMLElement.h" > #include "HTMLSelectElement.h" > #include "Icon.h" > +#if ENABLE(VIDEO) > #include "RenderMediaControls.h" > +#endif > #include "RenderSlider.h" > #include "Settings.h" > #include "SoftLinking.h" Please move conditional includes into their own paragraphs below unconditional includes before landing. r=me

Brent Fulgham

Comment 3 2009-05-24 18:42:00 PDT

Landed previously.

Note You need to log in before you can comment on or make changes to this bug.