| Summary: | Out-of-flow <br> should not trigger a line break | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kangil.han, koivisto, kondapallykalyan, mmaxfield, ntim, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=230048 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
zalan
2023-07-29 15:57:05 PDT
Created attachment 467157 [details]
Patch
Comment on attachment 467157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467157&action=review > LayoutTests/fast/inline/out-of-flow-forced-line-break.html:1 > +<style> Would be a really good WPT especially if browsers disagree here. Created attachment 467158 [details]
Patch
Created attachment 467159 [details]
Patch
alternatively we could just create a generic RenderBox for such out-of-flow line breaks so that we don't have to promote RenderLineBreak to a RenderBox subclass. (though most of this patch would still be needed) (In reply to Tim Nguyen (:ntim) from comment #2) > Comment on attachment 467157 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467157&action=review > > > LayoutTests/fast/inline/out-of-flow-forced-line-break.html:1 > > +<style> > > Would be a really good WPT especially if browsers disagree here. agree. we would still fail slightly more involved WPT tests though. Committed 266475@main (f71ea9e98639): <https://commits.webkit.org/266475@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467159 [details]. |