Bug 25962

Summary: wx port lacks triple click selection
Product: WebKit Reporter: Kevin Watters <kevinwatters>
Component: WebKit wxAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Minor    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
use a timer to catch triple clicks and create PlatformMouseEvents accordingly kevino: review+

Kevin Watters
Reported 2009-05-22 07:17:15 PDT
The wx port is not creating PlatformMouseEvents with click counts of 3, so it lacks triple click paragraph selection.
Attachments
use a timer to catch triple clicks and create PlatformMouseEvents accordingly (6.31 KB, patch)
2009-05-22 07:17 PDT, Kevin Watters 		kevino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kevin Watters
Comment 1 2009-05-22 07:17:47 PDT
Created attachment 30580 [details] use a timer to catch triple clicks and create PlatformMouseEvents accordingly
Eric Seidel (no email)
Comment 2 2009-05-22 07:25:31 PDT
Comment on attachment 30580 [details] use a timer to catch triple clicks and create PlatformMouseEvents accordingly Looks sane enough. Where is the test case? I assume Wx doesn't support DRT eventSender yet? Otherwise you should be able to easily write a test which tests this. r- for the lack of test case (or lack of ChangeLog explanation for why there isn't one). If it's not possible to test this yet, please file a bug about adding support to Wx's DumpRenderTree. Otherwise the patch looks fine and I would r+ it (or anyone else should feel free to) with the updated ChangeLog or test case.
Kevin Ollivier
Comment 3 2009-05-22 13:20:17 PDT
r+ from me. I've filed a meta bug on wx's DRT (https://bugs.webkit.org/show_bug.cgi?id=25967), and I really think that's all that's needed for now.
Adam Barth
Comment 4 2009-06-01 23:49:58 PDT
Will land.
Adam Barth
Comment 5 2009-06-01 23:53:12 PDT
This appears to already have been committed.
Note You need to log in before you can comment on or make changes to this bug.