Summary: | wx port lacks triple click selection | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kevin Watters <kevinwatters> | ||||
Component: | WebKit wx | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Kevin Watters
2009-05-22 07:17:15 PDT
Created attachment 30580 [details]
use a timer to catch triple clicks and create PlatformMouseEvents accordingly
Comment on attachment 30580 [details]
use a timer to catch triple clicks and create PlatformMouseEvents accordingly
Looks sane enough.
Where is the test case? I assume Wx doesn't support DRT eventSender yet? Otherwise you should be able to easily write a test which tests this.
r- for the lack of test case (or lack of ChangeLog explanation for why there isn't one). If it's not possible to test this yet, please file a bug about adding support to Wx's DumpRenderTree.
Otherwise the patch looks fine and I would r+ it (or anyone else should feel free to) with the updated ChangeLog or test case.
r+ from me. I've filed a meta bug on wx's DRT (https://bugs.webkit.org/show_bug.cgi?id=25967), and I really think that's all that's needed for now. Will land. This appears to already have been committed. |