Bug 259578

Summary: Add TraceScope to capture layout-ey activities only
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, ews-watchlist, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

zalan
Reported 2023-07-27 14:21:16 PDT
ssia
Attachments
Patch (1.55 KB, patch)
2023-07-27 14:22 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (2.39 KB, patch)
2023-07-27 15:10 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (3.76 KB, patch)
2023-07-27 15:49 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (3.73 KB, patch)
2023-07-27 15:50 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2023-07-27 14:22:39 PDT
Created attachment 467137 [details] Patch
Simon Fraser (smfr)
Comment 2 2023-07-27 14:32:18 PDT
Comment on attachment 467137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467137&action=review > Source/WebCore/page/LocalFrameViewLayoutContext.cpp:246 > + TraceScope tracingScope(LayoutStart, LayoutEnd); This no longer includes InViewSizeAdjust or InPostLayout, which don't have their own trace point coverage. This will make it harder to see how much tine they are taking for forced layouts.
zalan
Comment 3 2023-07-27 14:33:53 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 467137 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467137&action=review > > > Source/WebCore/page/LocalFrameViewLayoutContext.cpp:246 > > + TraceScope tracingScope(LayoutStart, LayoutEnd); > > This no longer includes InViewSizeAdjust or InPostLayout, which don't have > their own trace point coverage. This will make it harder to see how much > tine they are taking for forced layouts. sure but they are not layout either. do you want me to add new trace scopes?
zalan
Comment 4 2023-07-27 14:36:08 PDT
(In reply to zalan from comment #3) > (In reply to Simon Fraser (smfr) from comment #2) > > Comment on attachment 467137 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=467137&action=review > > > > > Source/WebCore/page/LocalFrameViewLayoutContext.cpp:246 > > > + TraceScope tracingScope(LayoutStart, LayoutEnd); > > > > This no longer includes InViewSizeAdjust or InPostLayout, which don't have > > their own trace point coverage. This will make it harder to see how much > > tine they are taking for forced layouts. > > sure but they are not layout either. do you want me to add new trace scopes? also don't we just re-enter LocalFrameViewLayoutContext::performLayout?
zalan
Comment 5 2023-07-27 15:10:50 PDT
Created attachment 467138 [details] Patch
zalan
Comment 6 2023-07-27 15:49:11 PDT
Created attachment 467139 [details] Patch
zalan
Comment 7 2023-07-27 15:50:36 PDT
Created attachment 467140 [details] Patch
EWS
Comment 8 2023-07-27 17:56:25 PDT
Committed 266372@main (703501c4541f): <https://commits.webkit.org/266372@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467140 [details].
Radar WebKit Bug Importer
Comment 9 2023-07-27 17:57:19 PDT
<rdar://problem/113006480>
Note You need to log in before you can comment on or make changes to this bug.