Bug 25955

Summary: Clean up messy third-party cookie blocking code
Product: WebKit Reporter: Adam Barth <abarth>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Step 1: Unify names
mjs: review+
Step 2: Remove bug-bait parameter mjs: review+

Adam Barth
Reported 2009-05-22 00:06:00 PDT
Our code for computing the first-party context for third-party cookie blocking is seriously messy. We have at least two names for the same context (policyBaseURL and mainDocumentURL). The name mainDocumentURL is particularly bad because it's occasionally a lie. Anyway, I'm working on a patch stream to clean this up.
Attachments
Step 1: Unify names (18.60 KB, patch)
2009-05-22 00:13 PDT, Adam Barth
mjs: review+
Step 2: Remove bug-bait parameter (7.78 KB, patch)
2009-05-22 00:13 PDT, Adam Barth
mjs: review+
Adam Barth
Comment 1 2009-05-22 00:13:08 PDT
Created attachment 30574 [details] Step 1: Unify names I'll add a ChangeLog before landing. ChangeLog + git = pain.
Adam Barth
Comment 2 2009-05-22 00:13:52 PDT
Created attachment 30575 [details] Step 2: Remove bug-bait parameter Again, I'll add a ChangeLog before landing.
Adam Barth
Comment 3 2009-05-22 00:14:47 PDT
I have some more ideas for cleaning this up further, but it's bed time for me.
Maciej Stachowiak
Comment 4 2009-05-22 00:32:07 PDT
Comment on attachment 30574 [details] Step 1: Unify names r=me
Maciej Stachowiak
Comment 5 2009-05-22 00:33:13 PDT
Comment on attachment 30575 [details] Step 2: Remove bug-bait parameter r=me
David Kilzer (:ddkilzer)
Comment 6 2009-05-22 06:19:07 PDT
(In reply to comment #1) > I'll add a ChangeLog before landing. ChangeLog + git = pain. ChangeLog +git + resolve-ChangeLogs = less pain
Adam Barth
Comment 7 2009-05-22 09:10:42 PDT
> ChangeLog +git + resolve-ChangeLogs = less pain Yeah, I tried that. Maybe I was doing it wrong, but resolve-ChangeLogs screwed up the ChangeLog royally.
Adam Barth
Comment 8 2009-05-22 10:35:24 PDT
Fixed in r44047 and r44048. There is more cleaning we can do, but we can work on that in another bug.
Note You need to log in before you can comment on or make changes to this bug.