Bug 25944

Summary:

[V8] Remove the uses of V8 Locker in worker execution code.

Product:

WebKit

Reporter:

Jian Li <jianli>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, jianli

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Patch	eric: review-
Proposed Patch	dglazkov: review+

Jian Li

Reported 2009-05-21 13:15:27 PDT

Remove the uses of V8 Locker in worker execution code.

Attachments
Proposed Patch (4.18 KB, patch) 2009-05-21 13:40 PDT, Jian Li	eric: review-	Details Formatted Diff Diff
Proposed Patch (4.48 KB, patch) 2009-05-22 16:29 PDT, Jian Li	dglazkov: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jian Li

Comment 1 2009-05-21 13:40:36 PDT

Created attachment 30553 [details] Proposed Patch

Eric Seidel (no email)

Comment 2 2009-05-22 07:06:52 PDT

Comment on attachment 30553 [details] Proposed Patch Your ChangeLog needs explanation as to why this change is correct and necessary. Is this possible to test? If so it needs a test case. If not, then the ChangeLog needs and explanation of why it's not possible to test, and possibly a link to a bug requesting additional features in our testing framework. Since it's not possible to run DumpRenderTree with V8 such a bug would be against test_shell in the Chromium tree. Thanks for the patch! Dimitri is probably your best reviewer for actual content however. Above was mostly just me applying standard patch review policy. :)

Jian Li

Comment 3 2009-05-22 16:29:56 PDT

Created attachment 30596 [details] Proposed Patch I've changed the ChangeLog per your feedback. Thanks.

Jian Li

Comment 4 2009-05-26 16:00:43 PDT

Committed as http://trac.webkit.org/changeset/44162

Note You need to log in before you can comment on or make changes to this bug.