Bug 259420
| Summary: | Handle focusability for plugin elements which has browsing context | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | UI Events | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | akeerthi, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
I came across another failing test case from Blink's case:
Blink: https://chromium.googlesource.com/chromium/src.git/+/a2c82afad86cf4f85f91df76f858434b15fe6b13
I tried it locally with test case and we fail without patching and patch is just:
>> In Source/WebCore/html/HTMLPlugInElement.cpp:
bool HTMLPlugInElement::isKeyboardFocusable(KeyboardEvent* event) const
{
if (HTMLFrameOwnerElement::isKeyboardFocusable(event))
return true;
return false;
}
>> In Source/WebCore/html/HTMLFrameOwnerElement.h:
Move: bool isKeyboardFocusable(KeyboardEvent*) const override; from 'Private' to 'Public'.
________
Just wanted to raise so we can track and fix it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 266286@main (61a5480546df): <https://commits.webkit.org/266286@main>
Reviewed commits have been landed. Closing PR #16041 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/112821601>