Bug 259246

Summary:	[contain-intrinsic-size] Use StyleBuilderConverter instead of StyleBuilderCustom
Product:	WebKit	Reporter:	Tim Nguyen (:ntim) <ntim>
Component:	CSS	Assignee:	Nobody <webkit-unassigned>
Status:	NEW
Severity:	Normal	CC:	rbuis, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=259237

Tim Nguyen (:ntim)

Reported 2023-07-15 11:45:19 PDT

Mistakes like bug 259237 would be avoided if we used StyleBuilderConverter. We'd need to store contain-intrinsic-size fields into a single struct instead of two separate RenderStyle items.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-07-22 11:46:16 PDT

<rdar://problem/112713755>

Rob Buis

Comment 2 2023-07-28 09:48:14 PDT

Tim, do you think this is still worth doing? I can give it a go, though I don't know if it would have fixed the inherit problem (I am not too familiar with StyleBuilderConverter)?

Note You need to log in before you can comment on or make changes to this bug.