Bug 25924
| Summary: | Windows DumpRenderTree needs multi-file Drag and Drop support (eventSender.beginDragWithFiles) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aroben, dbates, mculpepper, oliver |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=64285 | ||
| Bug Depends on: | 25852 | ||
| Bug Blocks: | 25913, 25916, 25923, 29666 | ||
Eric Seidel (no email)
Windows DumpRenderTree needs Drag and Drop support
The LayoutTests/platform/win/Skipped list clearly shows that DnD is not currently functional on windows DRT:
# Drag & Drop doesn't work correctly in DRT <rdar://5621244>
editing/pasteboard/drag-image-in-about-blank-frame.html
editing/pasteboard/get-data-text-plain-drop.html
editing/selection/drag-in-iframe.html
fast/events/drag-in-frames.html
fast/events/standalone-image-drag-to-editable.html
But it's very much needed to test things like bug 25916 and bug 25913 and bug 25923.
The mac side of multi-file dragging was added in bug 25852.
I'm hoping some of the Windows experts can help me understand what needs to be done here to fake this on Windows. I don't even see equivalent calls like [webview dragEntered:info] in the Windows DRT.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Roben (:aroben)
(In reply to comment #0)
> Windows DumpRenderTree needs Drag and Drop support
>
> The LayoutTests/platform/win/Skipped list clearly shows that DnD is not
> currently functional on windows DRT:
>
> # Drag & Drop doesn't work correctly in DRT <rdar://5621244>
> editing/pasteboard/drag-image-in-about-blank-frame.html
> editing/pasteboard/get-data-text-plain-drop.html
> editing/selection/drag-in-iframe.html
> fast/events/drag-in-frames.html
> fast/events/standalone-image-drag-to-editable.html
It is partially functional. But it's buggy.
> I don't even see equivalent calls like [webview dragEntered:info]
> in the Windows DRT.
<http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/win/EventSender.cpp?rev=43159#L191>
Eric Seidel (no email)
I would suspect a DragOver() call is also needed on eventSender.mouseMoveTo.
Adam Roben (:aroben)
(In reply to comment #2)
> I would suspect a DragOver() call is also needed on eventSender.mouseMoveTo.
We already do that, too: <http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/win/EventSender.cpp?rev=43159#L229>.
Eric Seidel (no email)
I swear I searched for it on the page... honest. :)
Marshall Culpepper
You guys have any more insight as to what's buggy about the current code in DRT? I might take a look at it so we can test win32 D&D functionality reliably..