| Summary: | [Gtk] Use ATK_ROLE_SECTION for divTag and ATK_ROLE_LABEL for labelTag | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joanmarie Diggs <jdiggs> | ||||||
| Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | apinheiro, commit-queue, walker.willie, xan.lopez, zecke | ||||||
| Priority: | P3 | Keywords: | Gtk | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 25531 | ||||||||
| Attachments: |
|
||||||||
Created attachment 30516 [details]
aforementioned test case
Now that I'm actually looking at these things from the other side.... :-) Bug 25530 is really two different bugs (and possibly three): 1. The accessible role being used with labels is wrong 2. The LABEL_FOR/LABELLED_BY relationship pair is missing (because, among other things, it seems accessible relationships haven't been implemented yet) 3. The accessible name of the AtkObject which is LABELLED_BY the label should be taken from the name of the label. And I'm starting to suspect that ain't going to happen magically on its own. So.... I've re-purposed this bug to deal with issue 1 (roles). 25530 can deal with the other two issues. Also, regarding this bit: > As for paragraphs contained in <div></div>, the expected hierarchy would > include both roles, thus: > > - ROLE_SECTION > - ROLE_PARAGRAPH > - ROLE_TEXT I suggested it because that's what Gecko does. I'm now starting to think doing that might be rather pointless, not to mention introduce a bunch of unneeded additional accessibles into the mix which might negatively impact performance. Therefore, I'm withdrawing this part for now. If, upon further consideration, I want it after all, I'll file a new bug for it. Created attachment 41370 [details] proposed patch - take 1 Tested with both the test case for this bug and for the test case for bug 25530. Seems fine but I'm waiting for Xan to comment. Comment on attachment 41370 [details]
proposed patch - take 1
Yep, looks good!
Comment on attachment 41370 [details] proposed patch - take 1 Clearing flags on attachment: 41370 Committed r49751: <http://trac.webkit.org/changeset/49751> All reviewed patches have been landed. Closing bug. |
Steps to reproduce: 1. Open the (to be) attached test case. 2. Use Accerciser to explore the accessible hierarchy Expected results: The text enclosed in <div></div> would be contained in an accessible object of ROLE_SECTION. Actual results: The text enclosed in <div></div> is contained in an accessible object of ROLE_PANEL. As for paragraphs contained in <div></div>, the expected hierarchy would include both roles, thus: - ROLE_SECTION - ROLE_PARAGRAPH - ROLE_TEXT