[Gtk] ROLE_ROW_HEADER should not be used for list item bullets/numbers

• Component: WebKitGTK
• Status: VERIFIED FIXED

[Joanmarie Diggs (irc: joanie)]

Steps to reproduce:

1. Open the (to be) attached test case.

2. Use Accerciser to explore the accessible hierarchy for list items.

Preferred results: The text for the list item bullet/number would be combined with the text of the item itself (i.e. in one object rather than two).

Expected results: Assuming it is necessary to maintain separate accessible objects for the item's bullet/number and the item's text, the bullet/number would be of ROLE_TEXT.

Actual results: The item's bullet/number is of ROLE_ROW_HEADER (a role associated and expected in tables; not list items).

[Joanmarie Diggs (irc: joanie)]

Created attachment 30515 [details]
aforementioned test case

[Jan Alonzo]

Created attachment 30541 [details]
use ROLE_TEXT for ListMarkerRole

[Xan Lopez]

Have you tried to figure out how to do the 'preferred result'? :)

[Xan Lopez]

Joannie, would it be useful to you if we commit this while we figure out if we can get the preferred solution?

[Joanmarie Diggs (irc: joanie)]

(In reply to comment #4)
> Joannie, would it be useful to you if we commit this while we figure out if we
> can get the preferred solution?
> 
I could go either way. That said, the preferred solution could be looked at as another bug, one related to (if not the same as) bug 25675. In both cases, multiple accessibles are present when only one (IMHO) should be. Jan fixed the most important issue reported here, namely the role.

Thanks!

[Xan Lopez]

Comment on attachment 30541 [details]
use ROLE_TEXT for ListMarkerRole

OK! Then let's commit this and let's try to fix the bigger issue in other bug. FWIW, I need to fix something similar to finish my get_text_at_offset patch, WebKit splits text separated by <br> in different elements, which makes testing the feature pretty complicated.

[Jan Alonzo]

Patch landed in r44104. 

[Joanmarie Diggs (irc: joanie)]

Verifying. Thanks!