Bug 25890

Summary: Implement Network logging channel on Mac
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Page LoadingAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch ddkilzer: review+

Alexey Proskuryakov
Reported 2009-05-20 08:06:41 PDT
Network logging is implemented in ResourceHandleCFNet, but not in ResourceHandleMac.
Attachments
proposed patch (10.47 KB, patch)
2009-05-20 08:12 PDT, Alexey Proskuryakov 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2009-05-20 08:12:26 PDT
Created attachment 30509 [details] proposed patch
David Kilzer (:ddkilzer)
Comment 2 2009-05-21 10:35:57 PDT
Comment on attachment 30509 [details] proposed patch >-- (void)connection:(NSURLConnection *)unusedConnection didFailWithError:(NSError *)error >+- (void)connection:(NSURLConnection *)connection didFailWithError:(NSError *)error > { >- UNUSED_PARAM(unusedConnection); >+ UNUSED_PARAM(connection); >+ >+ LOG(Network, "Handle %p delegate connection:%p didFailWithError:%@", m_handle, connection, error); Is NSError* converted to an NSString* implicitly here? r=me
Darin Adler
Comment 3 2009-05-21 10:48:36 PDT
(In reply to comment #2) > Is NSError* converted to an NSString* implicitly here? %@ logs the description of the object. So it doesn't just work with strings. The answer is effectively yes.
Alexey Proskuryakov
Comment 4 2009-05-21 11:52:54 PDT
Committed <http://trac.webkit.org/changeset/43974>.
Note You need to log in before you can comment on or make changes to this bug.