Bug 25863 – [Qt] Expose default encoding in qt

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Jakob Truelsen]

Please apply the following patch, exposing the default encoding property in QT

[Jakob Truelsen]

Created attachment 30470 [details]
Patch exposing the property

[Jakob Truelsen]

Created attachment 30471 [details]
Patch exposing the property

[Holger Freyther]

Comment on attachment 30471 [details]
Patch exposing the property

> Index: WebKit/qt/ChangeLog
> ===================================================================
> --- WebKit/qt/ChangeLog	(revision 43858)
> +++ WebKit/qt/ChangeLog	(working copy)
> @@ -1,3 +1,15 @@
> [phone]  Jakob Truelsen  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +	Expose the default text encoding property to QT

^^^ no tabs!


>  /*!
> +    \since 4.6
> +    Specifies the default text encoding system.
> +
> +    The \a encoding, must be a string describing an encoding such as “utf-8”, “iso-8859-1", etc.
> +
> +    \sa defaultTextEncoding()
> +*/
> +void QWebSettings::setDefaultTextEncoding(const QString &encoding) 
> +{
> +    d->defaultTextEncoding = encoding;
> +    d->apply();
> +}


For the doc string, maybe you should refer to the Qt TextCodec's for other encodings and that an empty string will use whatever default?

[Jakob Truelsen]

Created attachment 30607 [details]
A updated patch

Updated the patch, with propper whitespace, and a better documentation

[Holger Freyther]

Comment on attachment 30607 [details]
A updated patch

looks good, for Qt4.6 the api might change.

[Holger Freyther]

Thanks. Landed in r44090. Some hints for future patches. Try to not have whitespace in the patch, no tabs in general (the commit will be rejected), put a reference to the bug into the commit log. :)

[Simon Hausmann]

*** Bug 34751 has been marked as a duplicate of this bug. ***

[Simon Hausmann]

*** Bug 32849 has been marked as a duplicate of this bug. ***