Bug 258613
| Summary: | import-w3c-tests is deleting -expected.txt files of variant test files | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, gsnedders, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
youenn fablet
When reimporting webcodecs tests, I can see files like LayoutTests/imported/w3c/web-platform-tests/webcodecs/reconfiguring-encoder.https.any_h264_avc-expected.txt being removed while they should not.
We might want to refine our deletion heuristic.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/111770351>
Sam Sneddon [:gsnedders]
This is webkitpy.w3c.test_importer.TestImporter.remove_dangling_expectations; compare/contrast the logic there with that of webkitpy.port.base.Port._expected_baselines_for_suffixes.
Note that this runs unconditionally (i.e., even without --clean-dest-dir).
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/16348
EWS
Committed 266588@main (d8e12ca3753d): <https://commits.webkit.org/266588@main>
Reviewed commits have been landed. Closing PR #16348 and removing active labels.