Bug 258556
| Summary: | WasmSignalHandler.cpp doesn't compile on Windows | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Hayashida Ryuichi <Ryuichi.Hayashida> |
| Component: | JavaScriptCore | Assignee: | Hayashida Ryuichi <Ryuichi.Hayashida> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | Hironori.Fujii, webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 222315 | ||
Hayashida Ryuichi
wasm/WasmFaultSignalHandler.cpp doesn't compile on Windows because it uses wtf/threads/Signals.h. This is because Signals.h misses many APIs such as Signal class when it is not on Unix platform.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yusuke Suzuki
The same interface needs to be implemented on Windows with vectored exception handlers.
Radar WebKit Bug Importer
<rdar://problem/111733870>
Hayashida Ryuichi
I'd like to prioritize fixing llint for Wasm on Windows at first since it prevents Wasm feature from being enabled on Windows. For now, I want to just disable the signal handlers on Windows.
For implementing signals on Windows, I created the ticket bug259108. I'd like to work on signal handlers for Windows in the ticket once Wasm implementation starts to work on Windows.
Hayashida Ryuichi
Pull request: https://github.com/WebKit/WebKit/pull/15740
EWS
Committed 265964@main (62ac852fe74f): <https://commits.webkit.org/265964@main>
Reviewed commits have been landed. Closing PR #15740 and removing active labels.
Yusuke Suzuki
Note that wasm shared memory requires this as a mandatory option, so it must be implemented before enabling wasm.
Hayashida Ryuichi
Thank you. I need to understand how the shared memory works.