Bug 258528
| Summary: | Rename 'assert-selection.js' to 'assert_selection.js' due to reliance on exact script name | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
It is very clear bug and it is to update test expectation, where we get error in test script:
https://github.com/WebKit/WebKit/blob/0ed9d940afc3aac44f07b5f0b68626972aeeb6c1/LayoutTests/editing/inserting/insert-space-expected.txt#L4
--> It shows error here: resources/assert-selection.js:939:30
If I look at code: https://github.com/WebKit/WebKit/blob/0ed9d940afc3aac44f07b5f0b68626972aeeb6c1/LayoutTests/resources/assert-selection.js#L938
It relies on 'assert_selection.js' rather my name of 'assert-selection.js' (which I kept to make it consistent with WebKit test naming and scripts name.
I think it would be difficult to maintain in future to make this 'script name' change always, so I will just make script name consistent. So it is easier to always use up-to-date script from Chromium.
Just raising this bug for that purpose.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 265531@main (d164f4ce0298): <https://commits.webkit.org/265531@main>
Reviewed commits have been landed. Closing PR #15300 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/111354177>