Bug 25845

Summary:

[Qt] Fix QtWebKit pkgconfig dependencies

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed fix (+ removed some dead code)	staikos: review-
Second try.	staikos: review+

Laszlo Gombos

Reported 2009-05-17 20:39:02 PDT

QtWebKit should not depend on QtDBus. In addition QtWebKit only depends on QtXML for Qt version < 4.4.

Attachments
Proposed fix (+ removed some dead code) (1.53 KB, patch) 2009-05-17 20:48 PDT, Laszlo Gombos	staikos: review-	Details Formatted Diff Diff
Second try. (1.52 KB, patch) 2009-05-19 21:19 PDT, Laszlo Gombos	staikos: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Laszlo Gombos

Comment 1 2009-05-17 20:48:29 PDT

Created attachment 30434 [details] Proposed fix (+ removed some dead code)

George Staikos

Comment 2 2009-05-19 20:25:14 PDT

Comment on attachment 30434 [details] Proposed fix (+ removed some dead code) Better sort out which one you want.. The changelog says no QtXml if Qt < 4.4, the change says no QtXml if Qt >= 4.4. I think you just need to fix the changelog.

Laszlo Gombos

Comment 3 2009-05-19 21:19:16 PDT

Created attachment 30493 [details] Second try. Fix changelog.

Ariya Hidayat

Comment 4 2009-05-20 03:09:56 PDT

Landed in r43898 http://trac.webkit.org/changeset/43898

Note You need to log in before you can comment on or make changes to this bug.