Bug 25845

Summary: [Qt] Fix QtWebKit pkgconfig dependencies
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed fix (+ removed some dead code)
staikos: review-
Second try. staikos: review+

Description Laszlo Gombos 2009-05-17 20:39:02 PDT
QtWebKit should not depend on QtDBus. In addition QtWebKit only depends on QtXML for Qt version < 4.4.
Comment 1 Laszlo Gombos 2009-05-17 20:48:29 PDT
Created attachment 30434 [details]
Proposed fix (+ removed some dead code)
Comment 2 George Staikos 2009-05-19 20:25:14 PDT
Comment on attachment 30434 [details]
Proposed fix (+ removed some dead code)

Better sort out which one you want..  The changelog says no QtXml if Qt < 4.4, the change says no QtXml if Qt >= 4.4.  I think you just need to fix the changelog.
Comment 3 Laszlo Gombos 2009-05-19 21:19:16 PDT
Created attachment 30493 [details]
Second try.

Fix changelog.
Comment 4 Ariya Hidayat 2009-05-20 03:09:56 PDT
Landed in r43898
http://trac.webkit.org/changeset/43898