| Summary: | [macOS] Support WebM files with no track ID | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> |
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | twisniewski, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Eric Carlson
2023-06-22 08:23:58 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15193 Committed 265425@main (b9047adba096): <https://commits.webkit.org/265425@main> Reviewed commits have been landed. Closing PR #15193 and removing active labels. Could we get a rationale for why doing this is a good idea? Are there sites where this is causing Safari and Firefox to not play videos where Chromium plays them, for instance? Because to my untrained eye, this makes it sound like Safari is now going to play invalid webm files, while other browsers will not (at least I don't think Firefox will play them). The previous code would assert and crash when WebKit loaded a WebM file containing a track with no ID. We recently got hundreds of crash reports with this signature from many different devices. The crash reports are anonymized and do not contain any urls, so while we weren't able to identify the site to test it, given the frequency and number of crash reports we assume this kind of invalid webm files is supported in (an) other browser(s). |