Bug 258314

Summary: AX: AccessibilityNodeObject::addChildren() does not null-check its node before using it
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Tyler Wilcock 2023-06-20 12:21:30 PDT 
This leads to crashes.
Comment 1 Radar WebKit Bug Importer 2023-06-20 12:21:44 PDT 
<rdar://problem/111056760>
Comment 2 Tyler Wilcock 2023-06-20 12:22:28 PDT 
rdar://110703896
Comment 3 Tyler Wilcock 2023-06-20 12:25:39 PDT 
Created attachment 466765 [details]
Patch
Comment 4 chris fleizach 2023-06-20 12:38:05 PDT 
Comment on attachment 466765 [details]
Patch

should we put this in a local variable instead of calling node() 3 times?
Comment 5 Tyler Wilcock 2023-06-20 13:24:37 PDT 
Created attachment 466766 [details]
Patch
Comment 6 Tyler Wilcock 2023-06-20 13:24:51 PDT 
(In reply to chris fleizach from comment #4)
> Comment on attachment 466765 [details]
> Patch
> 
> should we put this in a local variable instead of calling node() 3 times?
Fixed!
Comment 7 EWS 2023-06-20 18:18:29 PDT 
Committed 265342@main (7c8d3655b4cb): <https://commits.webkit.org/265342@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466766 [details].