Bug 258290 – REGRESSION(262797@main): Menu permanently opened on github.com

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Kdwk]

Created attachment 466762 [details]
Screenshot of menu being open on github.com

1. Visit github.com/WebKit/WebKit/pulls
2. Menu is permanently opened

[Michael Catanzaro]

It seems you see a different version of github.com than I do. I don't have any of those buttons.

[Kdwk]

You might want to try to fully reload the website by clicking on the URL bar and pressing Enter. GitHub has redesigned their website.

[Michael Catanzaro]

Not for me. I think you're part of a test cohort.

[Michael Catanzaro]

*** Bug 258306 has been marked as a duplicate of this bug. ***

[Michael Catanzaro]

(In reply to Michael Catanzaro from comment #3)
> Not for me. I think you're part of a test cohort.

Well I've got the new version now. Dang, that's a seriously annoying menu. :P

[Calvin Walton]

For folks who don't see the updated UI, you may be able to enable it. Under the user menu, choose "Feature preview" and enable "Global Navigation Update".

You may also be able to use that menu to disable it if it has been enabled automatically.

[Kdwk]

Created attachment 467089 [details]
Screencast showing how to work around the problem

Disabling `display: revert` seems to do the trick

[Carlos Garcia Campos]

Pull request: https://github.com/WebKit/WebKit/pull/16309

[Michael Catanzaro]

Good work!

I am going to backport https://commits.webkit.org/261193@main to webkitglib/2.40, which is additionally required to fix this bug in stable.

[EWS]

Committed 266510@main (476e8fbe38b0): <https://commits.webkit.org/266510@main>

Reviewed commits have been landed. Closing PR #16309 and removing active labels.

[Michael Catanzaro]

(In reply to Michael Catanzaro from comment #9)
> Good work!
> 
> I am going to backport https://commits.webkit.org/261193@main to
> webkitglib/2.40, which is additionally required to fix this bug in stable.

Hm, the popover attribute doesn't exist in Safari stable at all. But backporting this commit is sufficient to fix the bug with github.com. So I guess I'll do that.

I'm nervous that this is enabling some web feature that is not fully-baked yet and may cause regressions on other websites, because there are lots more recent popover commits that I haven't sorted through and am not backporting, but fixing github.com seems most important.