Bug 258267
| Summary: | [Cocoa] Custom colorspaces in JPEG XL images don't work on downlevels | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> |
| Component: | Images | Assignee: | Myles C. Maxfield <mmaxfield> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Myles C. Maxfield
We build for downlevels with USE(JPEGXL) but not USE(LCMS). We should port the existing color conversion code to use Core Graphics.
The way to do this is:
1. tryDecodeICCColorProfile() can use CGColorSpaceCreateWithICCData() with a CFData
2. Create a CGColorConversionInfo from the source and destination color space
3. Use vImageConverter_CreateWithCGColorConversionInfo() to create a converter
4. vImageConvert_AnyToAny()
We might need a custom refptr for the vImageConverter. We can probably do this with custom RefPtr traits, like I did in 264884@main
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Myles C. Maxfield
<rdar://problem/111012276>
Myles C. Maxfield
*** Bug 258285 has been marked as a duplicate of this bug. ***
Myles C. Maxfield
Pull request: https://github.com/WebKit/WebKit/pull/15098
EWS
Committed 265440@main (19b823079b6d): <https://commits.webkit.org/265440@main>
Reviewed commits have been landed. Closing PR #15098 and removing active labels.