Bug 25817

Summary: svg/dom/SVGScriptElement/script-load-and-error-events.svg is flakey
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, aroben, jamesr, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
improve failure output
none
proposed fix thorton: review+

Eric Seidel (no email)
Reported 2009-05-15 01:39:21 PDT
svg/dom/SVGScriptElement/script-load-and-error-events.svg is flakey We need to fix the test so it stops sometimes failing on the bots. We can also skip it if necessary. Example failure: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r43761%20(1061)/results.html
Attachments
improve failure output (4.06 KB, patch)
2013-09-13 15:18 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed fix (1.57 KB, patch)
2013-09-13 16:50 PDT, Alexey Proskuryakov 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-09-23 18:19:06 PDT
*** Bug 29700 has been marked as a duplicate of this bug. ***
Nikolas Zimmermann
Comment 2 2012-02-08 02:22:56 PST
*** Bug 46998 has been marked as a duplicate of this bug. ***
Nikolas Zimmermann
Comment 3 2012-02-08 02:23:34 PST
*** Bug 76558 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 4 2013-09-13 15:18:13 PDT
Created attachment 211597 [details] improve failure output This test fails very often. I cannot reproduce locally, and cannot find anything wrong through code inspection. Let's see if this additional information helps.
Tim Horton
Comment 5 2013-09-13 15:20:13 PDT
Comment on attachment 211597 [details] improve failure output View in context: https://bugs.webkit.org/attachment.cgi?id=211597&action=review > LayoutTests/svg/dom/SVGScriptElement/script-load-and-error-events.svg:-112 > - scriptElement.href.baseVal = "resources/not-existant.js"; Are you going to move this file, too?
Alexey Proskuryakov
Comment 6 2013-09-13 15:27:05 PDT
Comment on attachment 211597 [details] improve failure output Committed <http://trac.webkit.org/r155727>, clearing review flag.
Alexey Proskuryakov
Comment 7 2013-09-13 16:41:01 PDT
OK, so it says "FAIL: The following tests failed: 6 (actual result: )". This means that we are not done running tests 1-5 when we start test 6. One of those gets into errorEventHandler, and since lastTest variable is set, we get into endTest().
Alexey Proskuryakov
Comment 8 2013-09-13 16:43:31 PDT
Oh, but of course. Test 5 is expected to generate a load event first, and then an error event. We start test 6 as soon as we get the load event from test 5.
Alexey Proskuryakov
Comment 9 2013-09-13 16:50:59 PDT
Created attachment 211603 [details] proposed fix
Alexey Proskuryakov
Comment 10 2013-09-13 16:55:29 PDT
Committed <http://trac.webkit.org/r155733>.
Note You need to log in before you can comment on or make changes to this bug.