Bug 25814

Summary: m_spreadMethod accessed without initialization
Product: WebKit Reporter: Rahul Kuchhal <kuchhal>
Component: ImagesAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
URL: LayoutTests/fast/canvas/canvas-radial-gradient-spreadMethod.html
Attachments:
Description Flags
Patch
darin: review+
new patch without the tabs this time none

Rahul Kuchhal
Reported 2009-05-14 17:17:34 PDT
m_spreadMethod is not getting initialized in one of the constructors. Will append the patch in a minute.
Attachments
Patch (1.00 KB, patch)
2009-05-14 17:19 PDT, Rahul Kuchhal 		darin: review+
DetailsFormatted DiffDiff
new patch without the tabs this time (1.01 KB, patch)
2009-05-14 21:03 PDT, Rahul Kuchhal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rahul Kuchhal
Comment 1 2009-05-14 17:19:47 PDT
Created attachment 30364 [details] Patch
Darin Adler
Comment 2 2009-05-14 19:31:12 PDT
Comment on attachment 30364 [details] Patch > + Initialize m_spreadMethod in the second constructor too. Not sure if > + a test case can be written, so no test case. > + https://bugs.webkit.org/show_bug.cgi?id=25814 The tabs in this ChangeLog will cause extra work for whoever commits the patch.
Rahul Kuchhal
Comment 3 2009-05-14 21:03:37 PDT
Created attachment 30365 [details] new patch without the tabs this time
Eric Seidel (no email)
Comment 4 2009-05-14 22:39:45 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/graphics/Gradient.cpp Committed r43755 Thanks for the patch!
Note You need to log in before you can comment on or make changes to this bug.