Bug 25804

Summary: symbols in win32 libraries also use leading underscore
Product: WebKit Reporter: Fridrich Strba <fridrich.strba>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, erik-webkit, jmalonzo, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
This patch adds underscore to functions written in asembly even for win32
none
Hopefully a fully compliant patch mjs: review+

Fridrich Strba
Reported 2009-05-14 13:33:42 PDT
Following patch solves some linking issues when building with mingw (gcc for win32). The functions written in assembly need to have leading underscore
Attachments
This patch adds underscore to functions written in asembly even for win32 (974 bytes, patch)
2009-05-14 13:35 PDT, Fridrich Strba 		no flags
DetailsFormatted DiffDiff
Hopefully a fully compliant patch (1.59 KB, patch)
2009-05-15 01:51 PDT, Fridrich Strba 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fridrich Strba
Comment 1 2009-05-14 13:35:04 PDT
Created attachment 30353 [details] This patch adds underscore to functions written in asembly even for win32
Holger Freyther
Comment 2 2009-05-14 20:29:57 PDT
One general remark. Please read http://webkit.org/coding/contributing.html.
Fridrich Strba
Comment 3 2009-05-15 01:51:22 PDT
Created attachment 30378 [details] Hopefully a fully compliant patch
Maciej Stachowiak
Comment 4 2009-05-21 23:01:04 PDT
Is this still correct when building with Visual Studio? Should it be ifdef'd to limit it to mingw on Windows perhaps?
Fridrich Strba
Comment 5 2009-05-21 23:57:10 PDT
The code is already in a branch that is compiled only #if !COMPILER(MSVC)
Fridrich Strba
Comment 6 2009-05-22 00:10:08 PDT
Sorry, a precision not in the branch where !COMPILER(MSVC), but in the branch where COMPILER(GCC) which is equivalent for our purposes here :)
Maciej Stachowiak
Comment 7 2009-05-22 00:58:24 PDT
Comment on attachment 30378 [details] Hopefully a fully compliant patch r=me then
Xan Lopez
Comment 8 2009-05-25 08:48:39 PDT
Landed as r44131.
Note You need to log in before you can comment on or make changes to this bug.