Summary: | [ iOS, macOS ] imported/w3c/web-platform-tests/html/rendering/the-details-element/summary-text-decoration.html is a constant ImageOnly failure | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bri Harris <bharris9> | ||||
Component: | New Bugs | Assignee: | Bri Harris <bharris9> | ||||
Status: | NEW --- | ||||||
Severity: | Normal | CC: | ahmad.saleem792, cdumez, karlcow, koivisto, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=227282 https://bugs.webkit.org/show_bug.cgi?id=258005 |
||||||
Bug Depends on: | |||||||
Bug Blocks: | 252223 | ||||||
Attachments: |
|
Description
Bri Harris
2023-06-07 14:20:24 PDT
I was able to replicate this failure on Ventura ToT as follows: run-webkit-tests --root imported/w3c/web-platform-tests/html/rendering/the-details-element/summary-text-decoration.html Pull request: https://github.com/WebKit/WebKit/pull/14762 Test gardening commit 264957@main (2dd4f2cd5de8): <https://commits.webkit.org/264957@main> Reviewed commits have been landed. Closing PR #14762 and removing active labels. This test was marked as failing since it was imported in 2020, but it was supposed to have been fixed in https://commits.webkit.org/264901@main, so the expectation was removed. EWS didn't tell us about this because bug 258005. (In reply to Alexey Proskuryakov from comment #5) > This test was marked as failing since it was imported in 2020, but it was > supposed to have been fixed in https://commits.webkit.org/264901@main, so > the expectation was removed. > > EWS didn't tell us about this because bug 258005. My commit was to introduce 'underline' (text decoration propogation), which was not done before and it seems to load fine when locally I did patch and since WPT had test coverage, I just enable the same tests but it seems 'underline' we get but it might cause 'bullet' or 'triangle' to get squashed. Should we revert our patch or consider it is just one test with 'ImageOnly failure'? and undo expectation? |