Bug 257832

Summary: [ iOS, macOS ] imported/w3c/web-platform-tests/html/rendering/the-details-element/summary-text-decoration.html is a constant ImageOnly failure
Product: WebKit Reporter: Bri Harris <bharris9>
Component: New BugsAssignee: Bri Harris <bharris9>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ahmad.saleem792, cdumez, karlcow, koivisto, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=227282
https://bugs.webkit.org/show_bug.cgi?id=258005
Bug Depends on:    
Bug Blocks: 252223    
Attachments:
Description Flags
Image Diffs none

Attachments
Image Diffs (6.30 KB, text/html)
2023-06-07 14:20 PDT, Bri Harris 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-06-07 14:20:42 PDT
<rdar://problem/110421013>
Bri Harris
Comment 2 2023-06-07 14:29:43 PDT
I was able to replicate this failure on Ventura ToT as follows: run-webkit-tests --root imported/w3c/web-platform-tests/html/rendering/the-details-element/summary-text-decoration.html
Bri Harris
Comment 3 2023-06-07 14:35:32 PDT
Pull request: https://github.com/WebKit/WebKit/pull/14762
EWS
Comment 4 2023-06-07 14:37:32 PDT
Test gardening commit 264957@main (2dd4f2cd5de8): <https://commits.webkit.org/264957@main> Reviewed commits have been landed. Closing PR #14762 and removing active labels.
Alexey Proskuryakov
Comment 5 2023-06-12 22:22:51 PDT
This test was marked as failing since it was imported in 2020, but it was supposed to have been fixed in https://commits.webkit.org/264901@main, so the expectation was removed. EWS didn't tell us about this because bug 258005.
Ahmad Saleem
Comment 6 2023-06-13 01:41:14 PDT
(In reply to Alexey Proskuryakov from comment #5) > This test was marked as failing since it was imported in 2020, but it was > supposed to have been fixed in https://commits.webkit.org/264901@main, so > the expectation was removed. > > EWS didn't tell us about this because bug 258005. My commit was to introduce 'underline' (text decoration propogation), which was not done before and it seems to load fine when locally I did patch and since WPT had test coverage, I just enable the same tests but it seems 'underline' we get but it might cause 'bullet' or 'triangle' to get squashed. Should we revert our patch or consider it is just one test with 'ImageOnly failure'? and undo expectation?
Ahmad Saleem
Comment 7 2024-11-23 18:26:15 PST
Fixed by bug 157323 ^ It removed expectation and there is no issue at all.
Ahmad Saleem
Comment 8 2024-11-23 18:26:40 PST
*** This bug has been marked as a duplicate of bug 157323 ***
Note You need to log in before you can comment on or make changes to this bug.