Bug 257788

Summary:	Investigate using Markable instead of std::optional for ScrollbarColor
Product:	WebKit	Reporter:	Luke Warlow <lwarlow>
Component:	CSS	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED INVALID
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari 16
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	257571
Bug Blocks:	231590

Luke Warlow

Reported 2023-06-07 03:21:21 PDT

We should check with the dump-class-layout, but the optional might make it align at 12 bytes (4 for each StyleColor). Using a custom Markable<ScrollbarColor> when any of the underlying color is invalid could save 4 bytes

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-06-14 03:22:17 PDT

<rdar://problem/110765163>

Luke Warlow

Comment 2 2023-06-16 03:26:22 PDT

Implemented as part of initial bug

Note You need to log in before you can comment on or make changes to this bug.